tests: Test without a cache directory by default
authorDan Nicholson <dbn@endlessos.org>
Mon, 19 Apr 2021 17:00:20 +0000 (11:00 -0600)
committerDan Nicholson <dbn@endlessos.org>
Mon, 19 Apr 2021 17:09:44 +0000 (11:09 -0600)
commite660855796a40ad417d13cbe081bd62e56a1c6f5
tree3a35f3f166ee0494f003e72bd3cdf7c5d108bc71
parent2458df446f65083df6ef4580b69839045c5985ed
tests: Test without a cache directory by default

Several tests generate summaries and then expect to use the generated
summary immediately. However, this can cause intermittent test failures
when they inadvertantly get a cached summary file. This typically
happens when the test is run on a filesystem that doesn't support user
extended attributes. In that case, the caching code can only use the
last modified time, which only has 1 second granularity. If tests don't
carefully manage the summary modification times or the repo cache then
they are likely subject to races in some test environments.

This introduces an environment variable `OSTREE_SKIP_CACHE` that
prevents the repo from using a cache directory. This is enabled by
default in tests and disabled for tests that are a explicitly trying to
test the caching behavior.

Fixes: #2313
Fixes: #2351
src/libostree/ostree-repo.c
tests/libtest.sh
tests/test-pull-summary-caching.sh
tests/test-pull-summary-sigs.sh
tests/test-signed-pull-summary.sh